Skip to content

Fix check-commits trigger to not require base change #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2025
Merged

Fix check-commits trigger to not require base change #2110

merged 1 commit into from
Jul 11, 2025
+4 −4

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Jul 11, 2025

We should not required a PR base change, we should only allow it to check the commits.

Found when looking at why rust-lang/rust#143794 didn't get the beta branch warning.

@Urgau Urgau requested a review from Kobzol July 11, 2025 17:54
@Urgau Urgau changed the title Fix check-commits trigger to not required base change Fix check-commits trigger to not require base change Jul 11, 2025
Kobzol
Kobzol approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, I remember staring hard at this and I still missed this "obvious" bug. Complex conditions are.. complex :)

@Kobzol Kobzol added this pull request to the merge queue Jul 11, 2025
Merged via the queue into rust-lang:master with commit 3510332 Jul 11, 2025
3 checks passed
@Urgau Urgau mentioned this pull request Jul 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kobzol Kobzol Kobzol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Urgau @Kobzol